Skip to content

Commit

Permalink
fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
Ole Markus With committed Aug 24, 2020
1 parent 4043791 commit 3d589e9
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion pkg/resources/digitalocean/cloud.go
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ func buildCloudInstanceGroup(c *Cloud, ig *kops.InstanceGroup, g DOInstanceGroup
for _, member := range g.Members {

// TODO use a hash of the godo.DropletCreateRequest fields for second and third parameters.
_, err := cg.NewCloudInstance(member, cloudinstances.CloudInstanceStatusReady, nodeMap)
_, err := cg.NewCloudInstance(member, cloudinstances.CloudInstanceStatusNeedsUpdate, nodeMap)
if err != nil {
return nil, fmt.Errorf("error creating cloud instance group member: %v", err)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/resources/spotinst/resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ func registerCloudInstances(instanceGroup *cloudinstances.CloudInstanceGroup, no
instance.Id(), instance.CreatedAt().Format(time.RFC3339),
currentInstanceGroupName, instanceGroupUpdatedAt.Format(time.RFC3339))

status := cloudinstances.CloudInstanceStatusReady
status := cloudinstances.CloudInstanceStatusUpToDate
if newInstanceGroupName != currentInstanceGroupName {
status = cloudinstances.CloudInstanceStatusNeedsUpdate
}
Expand Down
2 changes: 1 addition & 1 deletion upup/pkg/fi/cloudup/aliup/status.go
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ func buildCloudInstanceGroup(c ALICloud, ig *kops.InstanceGroup, g ess.ScalingGr
klog.Warningf("ignoring instance with no instance id: %s", i)
continue
}
status := cloudinstances.CloudInstanceStatusReady
status := cloudinstances.CloudInstanceStatusUpToDate
if newLaunchConfigName != i.ScalingConfigurationId {
status = cloudinstances.CloudInstanceStatusNeedsUpdate
}
Expand Down
2 changes: 1 addition & 1 deletion upup/pkg/fi/cloudup/awsup/aws_cloud.go
Original file line number Diff line number Diff line change
Expand Up @@ -776,7 +776,7 @@ func awsBuildCloudInstanceGroup(c AWSCloud, cluster *kops.Cluster, ig *kops.Inst
continue
}
currentConfigName := findInstanceLaunchConfiguration(i)
status := cloudinstances.CloudInstanceStatusReady
status := cloudinstances.CloudInstanceStatusUpToDate
if newConfigName != currentConfigName {
status = cloudinstances.CloudInstanceStatusNeedsUpdate
}
Expand Down
2 changes: 1 addition & 1 deletion upup/pkg/fi/cloudup/openstack/server_group.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func osBuildCloudInstanceGroup(c OpenstackCloud, cluster *kops.Cluster, ig *kops
observedName := fmt.Sprintf("%s-%s", clusterObservedGeneration, igObservedGeneration)
generationName := fmt.Sprintf("%d-%d", cluster.GetGeneration(), ig.Generation)

status := cloudinstances.CloudInstanceStatusReady
status := cloudinstances.CloudInstanceStatusUpToDate
if generationName != observedName {
status = cloudinstances.CloudInstanceStatusNeedsUpdate
}
Expand Down

0 comments on commit 3d589e9

Please sign in to comment.