Skip to content

Commit

Permalink
Remove workaround for socket activation on CentOS/RHEL distros
Browse files Browse the repository at this point in the history
  • Loading branch information
Ciprian Hacman committed Jul 3, 2020
1 parent 8760823 commit 42a92bf
Showing 1 changed file with 4 additions and 21 deletions.
25 changes: 4 additions & 21 deletions nodeup/pkg/model/docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -413,9 +413,7 @@ func (b *DockerBuilder) Build(c *fi.ModelBuilderContext) error {
c.AddTask(packageTask)

c.AddTask(b.buildDockerGroup())
if b.Distribution.IsDebianFamily() {
c.AddTask(b.buildSystemdSocket())
}
c.AddTask(b.buildSystemdSocket())
} else {
var extraPkgs []*nodetasks.Package
for name, pkg := range dv.ExtraPackages {
Expand Down Expand Up @@ -531,33 +529,18 @@ func (b *DockerBuilder) buildSystemdSocket() *nodetasks.Service {
}

func (b *DockerBuilder) buildSystemdService(dockerVersionMajor int, dockerVersionMinor int) *nodetasks.Service {
usesDockerSocket := true

manifest := &systemd.Manifest{}
manifest.Set("Unit", "Description", "Docker Application Container Engine")
manifest.Set("Unit", "Documentation", "https://docs.docker.com")

if b.Distribution.IsRHELFamily() {
// See https://github.com/docker/docker/pull/24804
usesDockerSocket = false
}

if usesDockerSocket {
manifest.Set("Unit", "After", "network.target docker.socket")
manifest.Set("Unit", "Requires", "docker.socket")
} else {
manifest.Set("Unit", "After", "network.target")
}
manifest.Set("Unit", "After", "network.target docker.socket")
manifest.Set("Unit", "Requires", "docker.socket")

manifest.Set("Service", "Type", "notify")
manifest.Set("Service", "EnvironmentFile", "/etc/sysconfig/docker")
manifest.Set("Service", "EnvironmentFile", "/etc/environment")

if usesDockerSocket {
manifest.Set("Service", "ExecStart", "/usr/bin/dockerd -H fd:// \"$DOCKER_OPTS\"")
} else {
manifest.Set("Service", "ExecStart", "/usr/bin/dockerd \"$DOCKER_OPTS\"")
}
manifest.Set("Service", "ExecStart", "/usr/bin/dockerd -H fd:// \"$DOCKER_OPTS\"")

manifest.Set("Service", "ExecReload", "/bin/kill -s HUP $MAINPID")
// kill only the docker process, not all processes in the cgroup
Expand Down

0 comments on commit 42a92bf

Please sign in to comment.