Skip to content

Commit

Permalink
Merge pull request #9320 from hakman/install-all-cni-binaries
Browse files Browse the repository at this point in the history
Install all CNI plugin binaries for all network plugins
  • Loading branch information
k8s-ci-robot authored Jun 10, 2020
2 parents cc45d02 + 4c1db82 commit 4af83f3
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 13 deletions.
4 changes: 0 additions & 4 deletions nodeup/pkg/model/networking/calico.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ func (b *CalicoBuilder) Build(c *fi.ModelBuilderContext) error {
return nil
}

if err := b.AddCNIBinAssets(c, []string{"flannel"}); err != nil {
return err
}

// @check if tls is enabled and if so, we need to download the client certificates
if !b.UseEtcdManager() && b.UseEtcdTLS() {
name := "calico-client"
Expand Down
4 changes: 0 additions & 4 deletions nodeup/pkg/model/networking/canal.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ func (b *CanalBuilder) Build(c *fi.ModelBuilderContext) error {
return nil
}

if err := b.AddCNIBinAssets(c, []string{"flannel"}); err != nil {
return err
}

buildFlannelTxChecksumOffloadDisableService(c)

return nil
Expand Down
16 changes: 15 additions & 1 deletion nodeup/pkg/model/networking/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,28 @@ var _ fi.ModelBuilder = &CommonBuilder{}

// Build is responsible for copying the common CNI binaries
func (b *CommonBuilder) Build(c *fi.ModelBuilderContext) error {
// Based on https://github.com/containernetworking/plugins/releases/tag/v0.7.5
assets := []string{
"bandwidth",
"bridge",
"dhcp",
"flannel",
"host-device",
"host-local",
"ipvlan",
"loopback",
"macvlan",
"portmap",
"ptp",
"tuning",
"vlan",
}

// Additions in https://github.com/containernetworking/plugins/releases/tag/v0.8.6
if b.IsKubernetesGTE("1.15") {
assets = append(assets, "bandwidth")
assets = append(assets, "firewall")
assets = append(assets, "sbr")
assets = append(assets, "static")
}

if err := b.AddCNIBinAssets(c, assets); err != nil {
Expand Down
4 changes: 0 additions & 4 deletions nodeup/pkg/model/networking/flannel.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ func (b *FlannelBuilder) Build(c *fi.ModelBuilderContext) error {
return nil
}

if err := b.AddCNIBinAssets(c, []string{"flannel"}); err != nil {
return err
}

if networking.Flannel.Backend == "vxlan" {
buildFlannelTxChecksumOffloadDisableService(c)
}
Expand Down

0 comments on commit 4af83f3

Please sign in to comment.