Skip to content

Commit

Permalink
Added support for configuring disable-attach-detach-reconcile-sync in…
Browse files Browse the repository at this point in the history
… k-c-m config
  • Loading branch information
andersosthus committed May 5, 2020
1 parent 814dd97 commit 9409e2a
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 0 deletions.
5 changes: 5 additions & 0 deletions k8s/crds/kops.k8s.io_clusters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1395,6 +1395,11 @@ spec:
items:
type: string
type: array
disableAttachDetachReconcileSync:
description: DisableAttachDetachReconcileSync disables the reconcile
sync loop in the attach-detach controller. This can cause volumes
to become mismatched with pods
type: boolean
enableProfiling:
description: EnableProfiling enables profiling via web interface
host:port/debug/pprof/
Expand Down
3 changes: 3 additions & 0 deletions pkg/apis/kops/componentconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,9 @@ type KubeControllerManagerConfig struct {
// AttachDetachReconcileSyncPeriod is the amount of time the reconciler sync states loop
// wait between successive executions. Is set to 1 min by kops by default
AttachDetachReconcileSyncPeriod *metav1.Duration `json:"attachDetachReconcileSyncPeriod,omitempty" flag:"attach-detach-reconcile-sync-period"`
// DisableAttachDetachReconcileSync disables the reconcile sync loop in the attach-detach controller.
// This can cause volumes to become mismatched with pods
DisableAttachDetachReconcileSync *bool `json:"disableAttachDetachReconcileSync,omitempty" flag:"disable-attach-detach-reconcile-sync"`
// TerminatedPodGCThreshold is the number of terminated pods that can exist
// before the terminated pod garbage collector starts deleting terminated pods.
// If <= 0, the terminated pod garbage collector is disabled.
Expand Down
3 changes: 3 additions & 0 deletions pkg/apis/kops/v1alpha2/componentconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,9 @@ type KubeControllerManagerConfig struct {
// ReconcilerSyncLoopPeriod is the amount of time the reconciler sync states loop
// wait between successive executions. Is set to 1 min by kops by default
AttachDetachReconcileSyncPeriod *metav1.Duration `json:"attachDetachReconcileSyncPeriod,omitempty" flag:"attach-detach-reconcile-sync-period"`
// DisableAttachDetachReconcileSync disables the reconcile sync loop in the attach-detach controller.
// This can cause volumes to become mismatched with pods
DisableAttachDetachReconcileSync *bool `json:"disableAttachDetachReconcileSync,omitempty" flag:"disable-attach-detach-reconcile-sync"`
// TerminatedPodGCThreshold is the number of terminated pods that can exist
// before the terminated pod garbage collector starts deleting terminated pods.
// If <= 0, the terminated pod garbage collector is disabled.
Expand Down
2 changes: 2 additions & 0 deletions pkg/apis/kops/v1alpha2/zz_generated.conversion.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions pkg/apis/kops/v1alpha2/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions pkg/apis/kops/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9409e2a

Please sign in to comment.