Skip to content

Commit

Permalink
Add missing permissions for NLB creation
Browse files Browse the repository at this point in the history
  • Loading branch information
aledbf committed Dec 1, 2017
1 parent cf70f99 commit 9eb0dd4
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 0 deletions.
15 changes: 15 additions & 0 deletions pkg/model/iam/iam_builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,21 @@ func addMasterELBPolicies(p *Policy, resource stringorslice.StringOrSlice, legac
),
Resource: resource,
})

p.Statement = append(p.Statement, &Statement{
Sid: "kopsK8sNLBMasterPermsRestrictive",
Effect: StatementEffectAllow,
Action: stringorslice.Of(
"elasticloadbalancing:CreateListeners", // aws_loadbalancer.go
"elasticloadbalancing:DescribeListeners", // aws_loadbalancer.go
"elasticloadbalancing:CreateTargetGroup", // aws_loadbalancer.go
"elasticloadbalancing:DescribeTargetGroups", // aws_loadbalancer.go
"elasticloadbalancing:RegisterTargets", // aws_loadbalancer.go
"elasticloadbalancing:DescribeTargetHealth", // aws_loadbalancer.go
"ec2:DescribeVpcs", // aws_loadbalancer.go
),
Resource: resource,
})
}
}

Expand Down
16 changes: 16 additions & 0 deletions pkg/model/iam/tests/iam_builder_master_strict.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,22 @@
"*"
]
},
{
"Sid": "kopsK8sNLBMasterPermsRestrictive",
"Effect": "Allow",
"Action": [
"elasticloadbalancing:CreateListeners",
"elasticloadbalancing:DescribeListeners",
"elasticloadbalancing:CreateTargetGroup",
"elasticloadbalancing:DescribeTargetGroups",
"elasticloadbalancing:RegisterTargets",
"elasticloadbalancing:DescribeTargetHealth",
"ec2:DescribeVpcs"
],
"Resource": [
"*"
]
},
{
"Sid": "kopsMasterCertIAMPerms",
"Effect": "Allow",
Expand Down

0 comments on commit 9eb0dd4

Please sign in to comment.