Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup cloudup _master_* tags #835

Closed
krisnova opened this issue Nov 8, 2016 · 4 comments
Closed

Cleanup cloudup _master_* tags #835

krisnova opened this issue Nov 8, 2016 · 4 comments
Assignees
@krisnova
Milestone
1.5.1

Comments

@krisnova
Copy link
Contributor

krisnova commented Nov 8, 2016

After the new topology feature is implemented into kops - as a clean up effort I would like to port the _master_* YAML implementation into the topologies directory.

I would also like this feature to be complete with a full YAML clean up / documentation
As well as unit tests for the masters (if not already in the topology PR)

#694
@krisnova krisnova mentioned this issue Nov 8, 2016
Merged
@krisnova
Copy link
Contributor Author

krisnova commented Nov 9, 2016

This might go away with #744

@krisnova krisnova self-assigned this Nov 9, 2016
@krisnova krisnova added this to the 1.5 milestone Nov 9, 2016
@krisnova krisnova mentioned this issue Nov 30, 2016
Merged
6 tasks
@chrislovecnm
Copy link
Contributor

We have PR inbound thay may help with this ... I am looking through issues to test against #1183

Does this help?

@chrislovecnm chrislovecnm mentioned this issue Dec 19, 2016
Closed
27 tasks
@chrislovecnm
Copy link
Contributor

@kris-nova was enough done in #1183?

@krisnova
Copy link
Contributor Author

Oh yes - this is long gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krisnova krisnova

Labels
None yet
Projects
None yet
Milestone
1.5.1
Development

No branches or pull requests
2 participants
@chrislovecnm @krisnova