-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WireGuard support for Calico CNI #10037
Conversation
Welcome @h3poteto! |
Hi @h3poteto. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @h3poteto. Looking forward to see how this works in production.
Besides the suggestions, please also do the following:
- add a mention in docs about this
- rebase and bump the manifest version to
3.16.3-kops.2
in:
"k8s-1.16": "3.16.3-kops.1",
upup/models/cloudup/resources/addons/networking.projectcalico.org/k8s-1.16.yaml.template
Outdated
Show resolved
Hide resolved
/ok-to-test |
Looks great @h3poteto! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: h3poteto, hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
No, I will check it, so please wait a moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits in the doc.
@h3poteto Could you add the docs changes I proposed. I would like to merge this and release a new 1.19 alpha after that. |
@hakman I'm sorry to late. I merged it. |
Thanks @h3poteto! |
/retest |
/lgtm |
…-upstream-release-1.18 Automated cherry pick of #10037: Add WireGuard support for Calico CNI
Refs: #9753
I add new option to enable WireGuard on Calico.
Sample Configuration
Result of this configuration
Each node contain a field with a WireGuard public key, so it is succeeded.