-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more volume types #10073
Allow more volume types #10073
Conversation
/cc @rifelpet |
I'm looking at the latest version of the aws sdk and there's a function that returns a list of all EBS volume types, maybe we should use that? I don't see the function in our vendored version though, so we'll need to update it first. (too big to link to the line # directly) // VolumeType_Values returns all elements of the VolumeType enum
func VolumeType_Values() []string {
return []string{
VolumeTypeStandard,
VolumeTypeIo1,
VolumeTypeIo2,
VolumeTypeGp2,
VolumeTypeSc1,
VolumeTypeSt1,
}
} |
The SDK has been updated and I updated some similar references in #10075 |
Note that the original reason for the validation was that Given that setting a bad value here ends up in an unusable cluster, I'd rather do an allow list than a deny list. |
006d191
to
fe7da5b
Compare
Ah, I missed that earlier. That makes more sense, I think we can keep it as this list of strings for now. I was wondering if we can get this info from ec2.DescribeInstanceTypes but we can explore that separately. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #10072