Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more volume types #10073

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

olemarkus
Copy link
Member

Fixes #10072

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/api labels Oct 19, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2020
@olemarkus
Copy link
Member Author

/cc @rifelpet

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet October 19, 2020 17:22
@rifelpet
Copy link
Member

I'm looking at the latest version of the aws sdk and there's a function that returns a list of all EBS volume types, maybe we should use that? I don't see the function in our vendored version though, so we'll need to update it first.

(too big to link to the line # directly)
https://raw.githubusercontent.com/aws/aws-sdk-go/master/service/ec2/api.go

// VolumeType_Values returns all elements of the VolumeType enum
func VolumeType_Values() []string {
	return []string{
		VolumeTypeStandard,
		VolumeTypeIo1,
		VolumeTypeIo2,
		VolumeTypeGp2,
		VolumeTypeSc1,
		VolumeTypeSt1,
	}
}

@rifelpet
Copy link
Member

The SDK has been updated and I updated some similar references in #10075

@olemarkus
Copy link
Member Author

Note that the original reason for the validation was that sc1 and st1 is not supported boot volumes. So I could take that slice and filter known unsupported types or I can explicitly list known good types. The standard type was missed from my side because most of the AWS docs doesn't mention it example 1 example 2.

Given that setting a bad value here ends up in an unusable cluster, I'd rather do an allow list than a deny list.

@olemarkus olemarkus force-pushed the validate-storage-type-fix branch from 006d191 to fe7da5b Compare October 20, 2020 06:54
@rifelpet
Copy link
Member

Ah, I missed that earlier. That makes more sense, I think we can keep it as this list of strings for now. I was wondering if we can get this info from ec2.DescribeInstanceTypes but we can explore that separately.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7f035dc into kubernetes:master Oct 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Root volume type 'standard' is no longer accepted since kops 1.19
3 participants