Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Digital Ocean] Use Debian10 as default image #10098

Merged
merged 2 commits into from
Nov 1, 2020

Conversation

srikiz
Copy link
Contributor

@srikiz srikiz commented Oct 24, 2020

Cilium leverages and builds on the kernel BPF functionality as well as various subsystems which integrate with BPF. Therefore, host systems are required to run Linux kernel version 4.9.17 or later to run a Cilium agent.

Using Debian10 should ensure we have the latest kernel that Cilium expects.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @srikiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2020
@hakman
Copy link
Member

hakman commented Oct 25, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2020
@olemarkus
Copy link
Member

Especially since citing cilium as the reason, I would go for Ubuntu. Debian uses nftables by default and cilium doesn't support that. Users need various workarounds for switching to iptables legacy to avoid having both legacy and nftables rules at play.

@hakman
Copy link
Member

hakman commented Nov 1, 2020

Thanks @srikiz.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, srikiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9b6f89f into kubernetes:master Nov 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 1, 2020
k8s-ci-robot added a commit that referenced this pull request Nov 2, 2020
…-upstream-release-1.19

Automated cherry pick of #10098: Use Debian10 image for DO
@srikiz srikiz deleted the DO-Use-Debian10-Image branch November 2, 2020 13:35
@srikiz
Copy link
Contributor Author

srikiz commented Nov 8, 2020

Thanks @hakman for cherry-picking this into release-1.19 !

@hakman
Copy link
Member

hakman commented Nov 8, 2020

😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants