Fix disabling spot instances when using launch templates #10198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/provider/aws
hakman
force-pushed
the
fix-spot-instance-2
branch
4 times, most recently
from
17819d5 to
6df9c2f
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
hakman
force-pushed
the
fix-spot-instance-2
branch
from
6df9c2f to
7b1592b
Compare
k8s-ci-robot
added
size/M
hakman
changed the title
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
hakman
force-pushed
the
fix-spot-instance-2
branch
from
7b1592b to
3265807
Compare
rifelpet
reviewed
Nov 8, 2020
| @@ -456,8 +456,8 @@ func (v *AutoscalingGroup) RenderAWS(t *awsup.AWSAPITarget, a, e, changes *Autos | |||
|
|
|||
| if changes.LaunchTemplate != nil { | |||
| spec := &autoscaling.LaunchTemplateSpecification{ | |||
| LaunchTemplateId: changes.LaunchTemplate.ID, | |||
| Version: &launchTemplateVersion, | |||
| LaunchTemplateName: changes.LaunchTemplate.ID, | |||
There was a problem hiding this comment.
I'm just curious, why is this change necessary?
There was a problem hiding this comment.
There is some strange mix in the current code as you can see in other sections of the file:
This will be changed in #10151 where I tested the fix initially and this is why the current "mismatch".
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extra fixes after #10187, to be able to remove the SpotPrice when already set.
/cc @rifelpet