Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bazel rules for Go to v0.24.7 #10240

Merged
merged 5 commits into from
Nov 18, 2020
Merged

Update Bazel rules for Go to v0.24.7 #10240

merged 5 commits into from
Nov 18, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Nov 15, 2020

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kops-controller labels Nov 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2020
rifelpet
rifelpet reviewed Nov 17, 2020
View reviewed changes
WORKSPACE
)

container_pull(
name = "distroless_base_debug_amd64",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are these debug images used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not being used, but are there for easier debugging during development.
They were there before, so this is the main reason for keeping them.

@hakman hakman mentioned this pull request Nov 17, 2020
Merged
rifelpet
rifelpet reviewed Nov 18, 2020
View reviewed changes
Makefile Show resolved Hide resolved
@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2020
@rifelpet
Copy link
Member

glad we're able to get over the 0.23 wall :)

@hakman
Copy link
Member Author

hakman commented Nov 18, 2020

glad we're able to get over the 0.23 wall :)

And without some ugly hack...

@k8s-ci-robot k8s-ci-robot merged commit fe07c9a into kubernetes:master Nov 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 18, 2020
@hakman hakman deleted the bazel-0.24.7 branch November 18, 2020 16:58
@hakman hakman mentioned this pull request Nov 19, 2020
Merged
@justinsb justinsb mentioned this pull request Nov 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@justinsb justinsb Awaiting requested review from justinsb

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kops-controller cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @k8s-ci-robot @rifelpet