Allow setting CPU limit and Mem request / limit for kube API server #10275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/nodeup
approved
hakman
requested changes
Nov 22, 2020
rdrgmnzs
force-pushed
the
kubeapi-mem-cpu-request-limit
branch
from
faf13ee to
da773ba
Compare
|
@rdrgmnzs maybe you want to cherry-pick to 1.19. |
k8s-ci-robot
added
the
lgtm
|
@hakman yep, was planning to. :D I'll do it once this gets merged |
|
/retest |
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 23, 2020
Automated cherrypick of #10275 onto release-1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting CPU limit and Mem request / limit for kube API server.
We had a user overload our API server with a few requests recently, which in turn caused the host to OOM different components causing debugging delays and stability issues. We eventually manually applied CPU & Mem Req/Limit to API server causing the API server pod to OOM instead of host level systems. This caused the cluster to become more stable while we debugged the underlying issue.
This change allows for those setting to be permanently set which would allow for a faster recover if something like this happens again in the future.