-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal cert-manager addon #10318
Conversation
I am a bit concerned about the 1.6 MB template that is being pulled into bindata.go also. |
Pretty huge CRDs. But can we do much about that? |
Not sure what can be done about it, but probably something should be done. |
cert-manager/cert-manager#3299 They are what they are. I can't think of a reason this would cause any harm. |
e060941
to
aca5a68
Compare
aca5a68
to
1ae09e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few Q:
- Why switch from the
cert-manager
namespace tokube-system
? - Why limit running on master nodes?
Co-authored-by: Ciprian Hacman <[email protected]>
Kops could technically have its own namespace for addons that doesn't strictly need to be in kube-system. But we don't have anything like this. So when it comes to PSPs and such, we don't have much choice but to deploy it to kube-system.
A lot of users run cert-manager on masters to leverage DNS ACME authentication. If/when we get IRSA more mature (and if this doesn't end up in a circular dependency) it could run on normal nodes using a dedicated IAM role. |
Thanks for the explanation. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There are several images involved here, so dropped the usual
Image
field until we have a better understanding how to handle this. Making at minimum the version configurable can be done well in time for 1.20 alpha anyway.Adding this PR is a prereq for some other addons + the kops-controller issuer.