Update etcd-manager to 3.0.20201202 #10351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The important PR we want to pick up is 369, fixing a bug when ListenMetricsURLS is set as an env var. Full changelist: * Release notes for 3.0.20201117 [kubernetes#364](kopeio/etcd-manager#364) * Fix gofmt [kubernetes#365](kopeio/etcd-manager#365) * Add gofmt check to github actions [kubernetes#366](kopeio/etcd-manager#366) * Add boilerplate to tools/deb-tools/main.go [kubernetes#367](kopeio/etcd-manager#367) * Do not set ListenMetricsURLS [kubernetes#369](kopeio/etcd-manager#369) * Fix bazel formatting [kubernetes#370](kopeio/etcd-manager#370)
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 2, 2020
…-upstream-release-1.19 Automated cherry pick of #10351: Update etcd-manager to 3.0.20201202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important PR we want to pick up is 369, fixing a bug when
ListenMetricsURLS is set as an env var.
There are other changes coming to etcd-manager: a go version bump to
1.15, updating kops vfs to include azure support, updating to klog2.
Those have some associated risk, so the intent is that this version
can be back-ported to kops 1.19 and then we can validate the bigger
changes on the master branch.
Full changelist: