-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for CentOS 8 #10368
Update docs for CentOS 8 #10368
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
docs/operations/images.md
Outdated
|
||
```bash | ||
aws ec2 describe-images --region us-east-1 --output table \ | ||
--owners 679593333241 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is the account ID that is kops' WellKnownAccountCentOS
but the account ID in the CentOS wiki is different: https://wiki.centos.org/Cloud/AWS It would be nice to figure out why they're different and if we should switch to the one mentioned upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the AWS Marketplace account. Changed it a bit and now references the AWS Provided Marketplace Images with Updates
:
https://wiki.centos.org/Cloud/AWS#AWS_Provided_Marketplace_Images_with_Updates
We could move to their new owner ID and images, but don't know if there's a lot of value and we would have to change the WellKnownAccountCentOS also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought about it a bit more and just changed it to the new CentOS repo. Easier to understand for anyone and probably will get the latest updates.
/lgtm |
Fixes: #10327