-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hack script improvements #10407
Hack script improvements #10407
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rifelpet: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
Previously we were tracking a list of kops packages in
hack/.packages
for use by thegoimports
python scripts. This replaces them with shell scripts (to match all of the other hack scripts) and uses lists of go files rather than packages, removing the need for.packages
and all of its dependent python code. The goimports scripts no longer rely onGOPATH
.We'll need to remove the verify-packages prow job before this merges. I will open a test-infra PR to remove verify-packages once the other jobs for this PR pass.
This also updates the apimachinery binaries to be compiled to
_output/bin
via the hack go submodule to match other development tools. This is the last dependency onGOPATH
, because thegengo
library that apimachinery uses assumes that the package name that we specify for generated files will be located at$GOPATH/src/$PACKAGE
. See the issue mentioned inMakefile
for more info.Lastly this has the pki unit tests ignore
KOPS_RSA_PRIVATE_KEY_SIZE
. This way we can have the env var set in our terminal to make the integration tests faster while not affecting the pki unit tests.