Move bootstrapchannelbuilder to a dedicated package #10409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/L
olemarkus
force-pushed
the
bcb-own-package
branch
from
1180c16 to
cc8f645
Compare
k8s-ci-robot
added
the
needs-rebase
olemarkus
force-pushed
the
bcb-own-package
branch
from
cc8f645 to
a91d3d3
Compare
k8s-ci-robot
added
needs-rebase
olemarkus
force-pushed
the
bcb-own-package
branch
2 times, most recently
from
824786e to
20ad30a
Compare
k8s-ci-robot
removed
the
needs-rebase
olemarkus
force-pushed
the
bcb-own-package
branch
from
20ad30a to
cdff469
Compare
|
We should consider moving the manifests closer to bootstrapchannelbuilder. They don't belong under upup/models anymore. |
|
I agree. Also consider some of pkg/model/components. Could be an idea to move these to pkg/model/addons/ at some point. |
k8s-ci-robot
added
the
needs-rebase
olemarkus
force-pushed
the
bcb-own-package
branch
from
cdff469 to
72073d3
Compare
k8s-ci-robot
added
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builder got annoyingly long, so I moved it to a dedicated subpackage where we can split it out into multiple files.
Maybe later on these could in turn be moved closer to other addon logic.
/kind cleanup