Bump helm to v3 #10426
Merged
Bump helm to v3 #10426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
olemarkus
force-pushed
the
bump-helm-v3
branch
from
9884463 to
19bb8ee
Compare
|
I wonder if the behavior changes in this PR's linked PRs is worthy of a release note. |
olemarkus
force-pushed
the
bump-helm-v3
branch
from
19bb8ee to
222ac02
Compare
k8s-ci-robot
added
needs-rebase
olemarkus
force-pushed
the
bump-helm-v3
branch
from
222ac02 to
3afe717
Compare
k8s-ci-robot
removed
the
needs-rebase
|
I changed this PR to use the full merge logic, removing some functions that was previously copy/pasted in. I ran this across our rather complex (hairy) templates and it seems to work fine. |
olemarkus
force-pushed
the
bump-helm-v3
branch
from
c87300d to
3d68860
Compare
k8s-ci-robot
added
the
needs-rebase
olemarkus
force-pushed
the
bump-helm-v3
branch
from
3d68860 to
24c9d03
Compare
k8s-ci-robot
removed
the
needs-rebase
|
nice, that's much cleaner 👍🏻 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.