Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gp3 Volume Type to etcd #10453

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Add gp3 Volume Type to etcd #10453

merged 1 commit into from
Jan 4, 2021

Conversation

msidwell
Copy link
Contributor

@msidwell msidwell commented Dec 17, 2020 •
edited
Loading

Fixes #10438

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Welcome @msidwell!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @msidwell. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 17, 2020
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Dec 17, 2020
@hakman
Copy link
Member

hakman commented Dec 17, 2020 •
edited
Loading

@msidwell This looks quite nice. Should be a good improvement to volumes.
Can you check for VolumeTypeIo1 in code? I think you need to add references to io2 and gp3 also in those locations.
Because you added a new field, you will also have to run make apimachinery to generate some files.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2020
@msidwell
Copy link
Contributor Author

it looks like the upstream auto scaling group sdk Ebs struct doesn't handle a throughput parameter, so I left that alone for now

@olemarkus
Copy link
Member

This looks good.

In your original post, you can write:
Fixes #10438

That will make github autoclose that issue once this PR merges

@hakman hakman mentioned this pull request Dec 18, 2020
Merged
@hakman hakman requested review from hakman and removed request for gjtempleton December 18, 2020 19:04
@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 27, 2020
@hakman
Copy link
Member

hakman commented Dec 27, 2020

/retest

@hakman
Copy link
Member

hakman commented Dec 27, 2020

it looks like the upstream auto scaling group sdk Ebs struct doesn't handle a throughput parameter, so I left that alone for now

OK, let's concentrate on the etcd part. Could you remove the code that is not required for this purpose and squash the commits?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2021
@msidwell
add gp3 volume default params
ebf05fa 
add io2 case and correct IOPS minimum value check

add gp3 case

add io2 and gp3 parameter ratio validation logic

add volumeThroughput parameter for disks that support it

add volumeThroughput components throughout ebs structs

add volumeThroughput to versioned api

updated api machinery and crds

apimachinery update
@msidwell
Copy link
Contributor Author

msidwell commented Jan 4, 2021

removed unnecessary changes beyond core etcd functionality and squashed to one commit

@hakman
Copy link
Member

hakman commented Jan 4, 2021

Perfect. Thanks @msidwell!
@olemarkus what do you think, should we add this to 1.19 to let people try it and see if it would be a good default for 1.20?
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, msidwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@olemarkus
Copy link
Member

Yeah let's. This is consistent with control plane volumes, isn't it?

@hakman
Copy link
Member

hakman commented Jan 4, 2021

Yeah let's. This is consistent with control plane volumes, isn't it?

There is no possibility to set throughput for control plane volumes at the moment. This would allow setting the throughput only for etcd volumes.

@hakman
Copy link
Member

hakman commented Jan 4, 2021

/retest

@olemarkus
Copy link
Member

That bit is indeed missing. Was more thinking of adding gp3 support and eventually defaulting to

@hakman
Copy link
Member

hakman commented Jan 4, 2021

Should be possible to add to launch templates also easily, but probably in the .1 release.

@hakman hakman mentioned this pull request Jan 4, 2021
Merged
@k8s-ci-robot k8s-ci-robot merged commit 6d5549e into kubernetes:master Jan 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jan 4, 2021
k8s-ci-robot added a commit that referenced this pull request Jan 4, 2021
@k8s-ci-robot
Merge pull request #10527 from hakman/automated-cherry-pick-of-#10453…
2ccc6f4 
…-upstream-release-1.19

Automated cherry pick of #10453: add gp3 volume default params
@hakman hakman mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus Awaiting requested review from olemarkus

@hakman hakman Awaiting requested review from hakman

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

AWS EBS gp3 and io2 Support for etcd Volumes
5 participants
@msidwell @k8s-ci-robot @hakman @olemarkus @rifelpet