Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spotinst: Specify Spot percentage per Instance Group #10551

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Spotinst: Specify Spot percentage per Instance Group #10551

merged 1 commit into from
Jan 11, 2021

Conversation

liranp
Copy link
Contributor

@liranp liranp commented Jan 10, 2021

Description

This PR allows users to specify Spot percentage per Instance Group (i.e. Ocean Launch Spec).

Usage Example

apiVersion: kops.k8s.io/v1alpha2
kind: InstanceGroup
metadata:
  labels:
    ...
    spotinst.io/spot-percentage: "70"
  name: ...
spec:
  ...

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 10, 2021
@k8s-ci-robot k8s-ci-robot added the area/provider/spotinst Issues or PRs related to spotinst provider label Jan 10, 2021
@liranp liranp changed the title Spotinst: c Spotinst: Specify Spot percentage per Instance Group (i.e. Ocean Launch Spec) Jan 10, 2021
@liranp liranp changed the title Spotinst: Specify Spot percentage per Instance Group (i.e. Ocean Launch Spec) Spotinst: Specify Spot percentage per Instance Group Jan 10, 2021
@liranp liranp force-pushed the feat-launchspec-strategy branch from 12b2be7 to 2f874be Compare January 10, 2021 13:22
@hakman
Copy link
Member

hakman commented Jan 11, 2021

Looks good. Thanks @liranp.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, liranp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
@hakman
Copy link
Member

hakman commented Jan 11, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit b3be647 into kubernetes:master Jan 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jan 11, 2021
@liranp liranp deleted the feat-launchspec-strategy branch January 11, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/spotinst Issues or PRs related to spotinst provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@liranp @hakman @k8s-ci-robot