-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DigitalOcean] add e2e tests #10575
[DigitalOcean] add e2e tests #10575
Conversation
Hi @srikiz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! glad to see it isn't much effort here to add support
/ok-to-test
Co-authored-by: Peter Rifel <[email protected]>
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet, srikiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Do we have a DO test account set up with kops already? I know there's one that Cluster API uses which is good for sharing with other CNCF projects, but wasn't sure if that has happened already (or may be happening implicitly). |
Initial work for adding e2e tests for DO.
Tested locally and it seems to work fine after adding the below command arguments.
go run kubetest2-kops/main.go --up --cloud-provider digitalocean --cluster-name test.myclustername.com \ --env KOPS_STATE_STORE=do://***-kops-space \ --env DIGITALOCEAN_ACCESS_TOKEN=bd5f*****472dae3 \ --env S3_ENDPOINT=sfo2.digitaloceanspaces.com \ --env S3_ACCESS_KEY_ID=PPO******NSRW \ --env S3_SECRET_ACCESS_KEY=rm******oIc \ --kops-binary-path /home/kops \ --ssh-public-key ~/.ssh/id_rsa.pub \ --kubernetes-version 1.19.2
I'll separately work with @timoreimann and @rifelpet to include the necessary environment variables.