-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate cluster cloud labels #10599
Validate cluster cloud labels #10599
Conversation
/test pull-kops-e2e-kubernetes-aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my point of view. Not sure if message can be improved.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We should apply the same validation to the instance group cloud labels |
kOps sets the reserved names before validation so there we already check that this value has not been changed. We could (should) change this behaviour so that these labels are not "sent through" the cluster spec. Then we could pass both maps through the same validation function. |
Co-authored-by: Ciprian Hacman <[email protected]>
/lgtm |
/retest |
Users can now set labels such as
Name
on all resources kOps creates. This breaks consequtive runs ofkops update cluster
as kOps cannot find its resources.Fixes #10596