feat: implement azure get api ingress status fn

[ngalantowicz]

Fix:

• Updates azure getting started doc to instruct correct feature flag value

Feature:

• Creates azureup network interfaces client with List method

Update:

• Uses vmScaleSet client and new network interfaces client to get masters ip for api ingress status

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @ngalantowicz!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ngalantowicz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ngalantowicz]

CLA has been signed 👍

[kenji-cloudnatix]

Thanks for making the change, @ngalantowicz ! I just have one comment on the use of cluster.AzureResourceGroupName().

[rifelpet]

hm the CLA bot still isn't detecting that you signed it. Are you sure you signed with the email address(es) associated with these git commits?

[ngalantowicz]

/check-cla

[rifelpet]

/check-cla

[ngalantowicz]

Thanks for the quick comments. Based on your suggestions i made the following updates

• utilize cluster.AzureResourceGroupName()
• use tags for master scale set discovery

		val, ok := scaleSet.Tags["KubernetesCluster"]
		val2, ok2 := scaleSet.Tags["k8s.io_role_master"]
		if ok && *val == cluster.Name && ok2 && *val2 == "1" {
			vmssName = *scaleSet.Name
			break
		}

• identify single network interface ip based on "Primary" metadata

               if *ni.Primary == true {
			for _, i := range *ni.IPConfigurations {
				ingresses = append(ingresses, kops.ApiIngressStatus{
					IP: *i.PrivateIPAddress,
				})
			}
		}

Regarding CLA:


According to the CNCF CLA Signing FAQ

...the Github user that the commit is attributed to (based on a match between the commit authorship and Github profile) must be linked to a Linux Foundation ID user (on the "social network logins" tab), who is authorized by a signed ICLA and/or a CCLA.

Not sure what i'm missing

[rifelpet]

@ngalantowicz i pulled the branch locally and noticed your git commit is authored by your gmail.com address rather than your t1cg.com address. here is some straight forward instructions for changing the email on an existing commit.

and then you can use git config user.email "[email protected]" in your kops repo to set it for new commits going forward.

[ngalantowicz]

/check-cla

@rifelpet Edited Author:

➜  kops git:(azureApiIngressStatus) git log -n1
commit 1396ee5777320a86b955441246f889a52dcf3b6a (HEAD -> azureApiIngressStatus, origin/azureApiIngressStatus)
Author: Nicholas Galantowicz <[email protected]>
Date:   Fri Jan 15 15:01:33 2021 -0500

    feat: implement azure getapiingressstatus fn

[ngalantowicz]

/check-cla

[rifelpet]

there we go!
/ok-to-test

[rifelpet]

@kenji-cloudnatix this looks good to me. If it looks good to you then we can get this merged

[kenji-cloudnatix]

Have minor comments, but looks good to me!

[rifelpet]

Thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kenji-cloudnatix, ngalantowicz, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ngalantowicz]

rebased

[rifelpet]

/lgtm