Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Digital Ocean] Add SFO3 region. Also update e2e tests to use full list of supported zones #10622

Merged
merged 3 commits into from
Jan 22, 2021
Merged

[Digital Ocean] Add SFO3 region. Also update e2e tests to use full list of supported zones #10622

merged 3 commits into from
Jan 22, 2021

Conversation

srikiz
Copy link
Contributor

@srikiz srikiz commented Jan 21, 2021

Small addition to use SFO3 to the list of regions DO KOPS supports.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 21, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @srikiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 21, 2021
@k8s-ci-robot k8s-ci-robot added area/documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2021
@srikiz srikiz force-pushed the DO-SupportCorrectRegions branch from e4df2b5 to 1c35e27 Compare January 21, 2021 04:30
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2021
@srikiz srikiz changed the title [Digital Ocean} Add SFO3 region for DO. Also update e2e tests to use full list of supported zones [Digital Ocean] Add SFO3 region for DO. Also update e2e tests to use full list of supported zones Jan 21, 2021
@srikiz srikiz changed the title [Digital Ocean] Add SFO3 region for DO. Also update e2e tests to use full list of supported zones [Digital Ocean] Add SFO3 region. Also update e2e tests to use full list of supported zones Jan 21, 2021
rifelpet
rifelpet reviewed Jan 21, 2021
View reviewed changes
tests/e2e/go.mod Outdated
@@ -8,5 +8,5 @@ require (
github.com/spf13/pflag v1.0.5
gopkg.in/yaml.v2 v2.3.0
k8s.io/klog/v2 v2.4.0
sigs.k8s.io/kubetest2 v0.0.0-20210115020551-4275dd0a0d63
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is downgrading the package. Any reason why that's necessary? Otherwise I think we can revert this go.mod and go.sum change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't realize that, thanks. I will revert the go.mod and go.sum change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rifelpet - I think it should be okay now. Please have a look when you get a chance. Thanks !

@srikiz srikiz force-pushed the DO-SupportCorrectRegions branch from 45c489d to bbe6924 Compare January 22, 2021 15:49
rifelpet
rifelpet reviewed Jan 22, 2021
View reviewed changes
tests/e2e/go.mod Outdated
@@ -9,4 +9,4 @@ require (
gopkg.in/yaml.v2 v2.3.0
k8s.io/klog/v2 v2.4.0
sigs.k8s.io/kubetest2 v0.0.0-20210115020551-4275dd0a0d63
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srikiz I think these trailing newline changes in go.mod and go.sum need to be reverted as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, updated.

rifelpet
rifelpet approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, srikiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021
@hakman
Copy link
Member

hakman commented Jan 22, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3d03968 into kubernetes:master Jan 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jan 22, 2021
@srikiz srikiz deleted the DO-SupportCorrectRegions branch October 25, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@mikesplain mikesplain Awaiting requested review from mikesplain

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@srikiz @k8s-ci-robot @hakman @rifelpet