-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not check DNS when Topology is Private #1063
Do not check DNS when Topology is Private #1063
Conversation
Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.
If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinsb I think u want to leave this one pending you API refactoring?
Just to let you know this #1183 will probably impact this PR. I appreciate your patience, and help! This PR is a big change that has some huge benefits. |
We need a rebase :) See #1206 as well |
Did you follow this as well: https://github.com/kubernetes/kops/blob/master/docs/development/api_updates.md? It is fresh off of the press, so I do not know if you did. Also @justinsb wants to review all of the API changes, for the time bit. I am going to assign this to him. Again thanks for your patience as we move to k8s api machinery code. The benefits are super exciting! |
It should be correct this time around, added it to the previous api version files per the doc and ran Thanks for the guide! 🏑 |
@justinsb can u review please |
Incidentally, as this compares to #1264, that PR is just getting private hosted zones working (and they do work), without addressing the issues of what they should look like. The remaining questions for me (which I think will determine the schema):
|
We need a rebase, and any updates on @justinsb comments? |
With the feature flag implemented I'll just close this PR. My two cents,
|
Based on @billyshambrook PR #810 and conversation.
I was not 100% certain how to implement @justinsb comments but wanted to give this an attempt using the new
--topology private
settings.Preference on the name?
DNS
=public
orprivate
The feature (or similar) would certainly be useful in our configurations where
<env>.company.internal
designation is typically used.This change is