[WIP] Rolling update improvements #1064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
krisnova
previously requested changes
Dec 5, 2016
| ) | ||
|
|
||
| var ( | ||
| // Hermione requires a PUBLIC SSH key to drop off on the cluster for access.. |
There was a problem hiding this comment.
@chrislovecnm - this has got to go and get squashed unfortunately
| var ( | ||
| // Hermione requires a PUBLIC SSH key to drop off on the cluster for access.. | ||
| // The private half of this key is carefully hidden in a place most users will never know about | ||
| DefaultSSHPublicKeyBytes = []byte("ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCnhkq2fUyDMImFAfiRItxuVNbcLc6CTj0Fipb/DWlNBhVSL34fJeUw4oFqPDuL0N2cUTsxH22drie/AOJCVzZ4f7OEECFAh6RD2I11GxqrlDppr4KjWBoV//XyGbPZa4NXg+Bpg0+UVefqjAQNiAIRmuJ8vBsl952Vkf46RIKNAznoNUI7vnYkfvU1eCCaFcWiysxfg8BALiKS4Trv00TmHO15PPuiHeYzeu4wAB+0Mtuc6uh4WmqIWOEe/jmIhdHXYniHm3AEtMjL1GVMly/QEKjANUFZCZsBFbm3S6T+o820reOXSSG1wW2XBfOSTNyGlBZJFnutQntBwvHpw6A9 [email protected]") |
There was a problem hiding this comment.
Get this key out of here please :)
| return nil, fmt.Errorf("error in create cluster name %v", err) | ||
| } | ||
|
|
||
| // TODO: setup dynamically |
There was a problem hiding this comment.
RE: Dynamically generated.. it would be fabulous if our tests could read in a cluster spec YAML file...
update tests and starting working on e2e
chrislovecnm
force-pushed
the
rolling-update-improvements
branch
from
70eeb4c to
c1d5011
Compare
|
Jenkins Kubernetes AWS e2e failed for commit c1d5011. Full PR test history. The magic incantation to run this job again is |
rochacon
reviewed
Dec 5, 2016
| ) | ||
|
|
||
| // Will execute a command given a raw command string | ||
| func ExecOuput(c, args string, env []string) (string, error) { |
There was a problem hiding this comment.
Is this a typo? Should it be ExecOutput?
|
Closing because I have done #1134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is