Allow attaching same external load balancer to multiple instance groups #10666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/provider/aws
rifelpet
reviewed
Jan 27, 2021
| @@ -86,7 +86,7 @@ resource "aws_autoscaling_group" "master-us-test-1a-masters-externallb-example-c | |||
| id = aws_launch_template.master-us-test-1a-masters-externallb-example-com.id | |||
| version = aws_launch_template.master-us-test-1a-masters-externallb-example-com.latest_version | |||
| } | |||
| load_balancers = ["my-external-elb-2", "my-external-elb-3"] | |||
| load_balancers = ["master-us-test-1a.masters.externallb.example.com-my-external-elb-1", "master-us-test-1a.masters.externallb.example.com-my-external-elb-2", "master-us-test-1a.masters.externallb.example.com-my-external-elb-3"] | |||
There was a problem hiding this comment.
I wouldn't expect the terraform and cloudformation outputs to be changing. We don't want to change the names of the load balancers we're attaching to the ASGs, only the names of their fi tasks
There was a problem hiding this comment.
True. These latest changes should do the trick.
I guess now this has to its way into 1.19 and 1.18?
hakman
force-pushed
the
same-lb-multiple-igs
branch
from
d006c75 to
e1c75c4
Compare
hakman
force-pushed
the
same-lb-multiple-igs
branch
from
e1c75c4 to
5fcd4e4
Compare
This was referenced Jan 27, 2021
Merged
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 27, 2021
…-upstream-release-1.19 Automated cherry pick of #10666: Allow attaching same external load balancer to multiple
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 27, 2021
…-upstream-release-1.18 Automated cherry pick of #10666: Allow attaching same external load balancer to multiple
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #10335
Fixes: #10664
/cc @rifelpet @rdrgmnzs