-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw error if path being set by kops set is not present in struct #10692
Throw error if path being set by kops set is not present in struct #10692
Conversation
Hi @bharath-123. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @rifelpet |
/ok-to-test |
7f9f10b
to
49f3ab0
Compare
/lgtm Thanks for improving this! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bharath-123, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently, when using kops set cluster <cluster_name> =, if the path is not present it fails silently. eg:
kops set cluster test-cluster.k8s.local spec.abc.def.ghi=jkl
will not throw any error despite the fields not being present in the kops.Cluster struct. This can lead to confusion and mistakes.This PR explicitly throws an error if a field being set using
kops set
does not exist in the associated struct.Fixes: #10647
Depends on: #10690