-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use expected LaunchTemplateId in updating ASG when MixedInstancePolicy is changed #10742
Conversation
Hi @h3poteto. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
…y is changed When user changes only mixedInstancePolicy, LaunchTemplateId is not changed. So it is not necessary to change LaunchTemplateId in AutoScalingGroup.
Thanks @h3poteto! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: h3poteto, hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-upstream-release-1.19 Automated cherry pick of #10742: Use expected LaunchTemplateId in updating ASG when
refs: #10718
When user changes only mixedInstancePolicy, LaunchTemplateId is not changed.
But current logic expect changes to LaunchTemplateId; therefore nil pointer dereference has occur.
In this case, it is not necessary to change LaunchTemplateId in AutoScalingGroup, so I fixed it.
I don't know the reason for this logic. If anyone knows why, please tell me.