Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotinst: Don't skip LB attachments when SpotinstHybrid is enabled #10961

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

liranp
Copy link
Contributor

@liranp liranp commented Mar 1, 2021

This PR resolves an issue with LB attachments of non-Spotinst managed instance groups. LB attachments shouldn't be skipped entirely when the SpotinstHybrid feature is enabled.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2021
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Mar 1, 2021
@hakman
Copy link
Member

hakman commented Mar 1, 2021

@liranp do you know if this fixes #10908?

@liranp
Copy link
Contributor Author

liranp commented Mar 1, 2021

@hakman Unfortunately, it doesn't, but I'll submit another PR later today to fix that issue as well.

@hakman
Copy link
Member

hakman commented Mar 1, 2021

No worries. Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
@liranp
Copy link
Contributor Author

liranp commented Mar 1, 2021

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit c83d234 into kubernetes:master Mar 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 1, 2021
k8s-ci-robot added a commit that referenced this pull request Mar 1, 2021
…-upstream-release-1.20

Automated cherry pick of #10961: fix: don't skip lb attachments when hybrid is enabled
@estahn
Copy link
Contributor

estahn commented Mar 1, 2021

@liranp Thanks for the quick turnaround!
@hakman Thanks for approving it.

@estahn
Copy link
Contributor

estahn commented Mar 1, 2021

@liranp @hakman Can we get this into the next 1.19 release?

@liranp liranp deleted the fix-lb-attachment branch March 2, 2021 11:09
@liranp
Copy link
Contributor Author

liranp commented Mar 2, 2021

@estahn You can work around it temporarily by downloading v1.19.1 from our fork.

@hakman
Copy link
Member

hakman commented Mar 2, 2021

I am not opposed to cherry-picking bug fixes to 1.19, but would leave it to @liranp to decide what and how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants