-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotinst: Don't skip LB attachments when SpotinstHybrid is enabled #10961
Conversation
@hakman Unfortunately, it doesn't, but I'll submit another PR later today to fix that issue as well. |
No worries. Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
…-upstream-release-1.20 Automated cherry pick of #10961: fix: don't skip lb attachments when hybrid is enabled
I am not opposed to cherry-picking bug fixes to 1.19, but would leave it to @liranp to decide what and how. |
This PR resolves an issue with LB attachments of non-Spotinst managed instance groups. LB attachments shouldn't be skipped entirely when the
SpotinstHybrid
feature is enabled.