Improve instance type validation error message #11043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
area/api
area/provider/aws
hakman
reviewed
Mar 13, 2021
pkg/apis/kops/validation/aws.go
Outdated
| @@ -153,7 +153,7 @@ func awsValidateInstanceTypeAndImage(instanceTypeFieldPath *field.Path, imageFie | |||
| } | |||
| if !found { | |||
| allErrs = append(allErrs, field.Invalid(instanceTypeFieldPath, instanceType, | |||
| fmt.Sprintf("machine type architecture does not match image architecture: %+v - %q", machineInfo.ProcessorInfo, imageArch))) | |||
| fmt.Sprintf("machine type architecture does not match image architecture: %+v - %s", strings.Join(fi.StringSliceValue(machineInfo.ProcessorInfo.SupportedArchitectures), ","), imageArch))) | |||
There was a problem hiding this comment.
I think now we don't need %+v anymore.
Suggested change
| fmt.Sprintf("machine type architecture does not match image architecture: %+v - %s", strings.Join(fi.StringSliceValue(machineInfo.ProcessorInfo.SupportedArchitectures), ","), imageArch))) | |
| fmt.Sprintf("machine type architecture does not match image architecture: %s - %s", strings.Join(fi.StringSliceValue(machineInfo.ProcessorInfo.SupportedArchitectures), ","), imageArch))) |
bharath-123
force-pushed
the
nit/fix-error-msg
branch
from
4fd89ae to
059c7ef
Compare
hakman
approved these changes
Mar 13, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
|
/test pull-kops-e2e-k8s-containerd |
This was referenced Mar 16, 2021
Closed
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 17, 2021
…-upstream-release-1.20 Automated cherry pick of #11043: Improve instance type validation error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be reasonably safe as the machineInfo field should not be nil on a valid instance type. Would like some opinions on this.