Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube-router to v1.2.3 #11124

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Mar 24, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2021
@hakman
Copy link
Member Author

hakman commented Mar 24, 2021

/retest

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 24, 2021
k8s-ci-robot added a commit that referenced this pull request Mar 24, 2021
…-upstream-release-1.20

Automated cherry pick of #11124: Update kube-router to v1.2.0
@hakman
Copy link
Member Author

hakman commented Mar 24, 2021

/retest

@hakman
Copy link
Member Author

hakman commented Mar 24, 2021

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 24, 2021
@hakman
Copy link
Member Author

hakman commented Mar 24, 2021

/test pull-kops-e2e-cni-kuberouter

@hakman hakman removed request for mikesplain and zetaab March 24, 2021 15:00
@murali-reddy
Copy link
Contributor

@hakman Did the CI fail becuase there were errors in the logs or was there a test failure as well?

We address the errors part in cloudnativelabs/kube-router#1054, ready to 1.2.1 release, but was wondering if this was the only issue.

@hakman
Copy link
Member Author

hakman commented Mar 25, 2021

@murali-reddy there were many failed tests. Tried 3 runs before reverting the change to see if I can reproduce it with v1.1.1.
You can see the test results and artifacts from one of the runs here:
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kops/11124/pull-kops-e2e-cni-kuberouter/1374613539594964992

@hakman hakman force-pushed the kube-router-1.2.0 branch from 7179ef4 to 3e74ad9 Compare March 25, 2021 15:06
@murali-reddy
Copy link
Contributor

@hakman Looking at the logs I am not able to figure what is going wrong. All the nodes end up in non-ready state after which tests are faling as nodes are not ready

Mar 25 15:28:30.198: FAIL: All nodes should be ready after test, Not ready nodes: ", ip-172-20-47-185.ap-northeast-1.compute.internal, ip-172-20-63-93.ap-northeast-1.compute.internal"
.....
Mar 25 16:09:09.931: All nodes should be ready after test, Not ready nodes: ", ip-172-20-45-197.ap-northeast-1.compute.internal, ip-172-20-47-185.ap-northeast-1.compute.internal, ip-172-20-48-60.        ap-northeast-1.compute.internal, ip-172-20-63-93.ap-northeast-1.compute.internal"

There is one test failure, I will check if that is causing any problem

{"msg":"FAILED [sig-network] Services should be able to change the type from NodePort to ExternalName [Conformance]","total":-1,"completed":5,"skipped":46,"failed":1,"failures":["[sig-network] Services should be able to change the type from NodePort to ExternalName [Conformance]"]}

@hakman
Copy link
Member Author

hakman commented Mar 26, 2021

Thanks @murali-reddy. Please let me know if you need any help debugging.

@murali-reddy
Copy link
Contributor

@hakman I am not quite familiar with kops CI tests. So I am not sure how to go about root causing in efficient way. Like I mentioned in earlier comment I analyzed the logs but I can only conclude that nodes were not ready (perhaps even after applying kube-router CNI). There was error dumping kube-router logs as well. Appriciate any help with how to go about it.

Do you mind doing manual install of cluster with kops and upgrading the latest version of kube-router and see if you run into any issue?

@hakman hakman force-pushed the kube-router-1.2.0 branch from 3e74ad9 to 29fcb36 Compare April 1, 2021 15:02
@hakman hakman changed the title Update kube-router to v1.2.0 Update kube-router to v1.2.1 Apr 1, 2021
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 20, 2021
@hakman hakman force-pushed the kube-router-1.2.0 branch from c2ae6df to 05d9fd1 Compare April 20, 2021 16:42
@hakman hakman changed the title Update kube-router to v1.2.1 [WIP] Update kube-router to v1.2.1 Apr 24, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2021
@hakman hakman removed approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 24, 2021
@hakman hakman force-pushed the kube-router-1.2.0 branch from 05d9fd1 to a3526bb Compare April 26, 2021 12:17
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021
@hakman hakman requested a review from olemarkus May 21, 2021 13:16
@hakman hakman removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@hakman hakman force-pushed the kube-router-1.2.0 branch from a3526bb to 91d6816 Compare June 7, 2021 02:25
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@hakman hakman changed the title [WIP] Update kube-router to v1.2.1 [WIP] Update kube-router to v1.2.3 Jun 7, 2021
@hakman
Copy link
Member Author

hakman commented Jun 7, 2021

The issue seems fixed in v.1.2.3 and tests pass now.

@hakman hakman changed the title [WIP] Update kube-router to v1.2.3 Update kube-router to v1.2.3 Jun 7, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2021
@hakman
Copy link
Member Author

hakman commented Jun 7, 2021

/test all

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Member Author

hakman commented Jun 7, 2021

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants