-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kube-router to v1.2.3 #11124
Update kube-router to v1.2.3 #11124
Conversation
/retest |
…-upstream-release-1.20 Automated cherry pick of #11124: Update kube-router to v1.2.0
/retest |
/hold |
@murali-reddy any ideas why this would not work with a simple version bump? |
/test pull-kops-e2e-cni-kuberouter |
@hakman Did the CI fail becuase there were errors in the logs or was there a test failure as well? We address the errors part in cloudnativelabs/kube-router#1054, ready to 1.2.1 release, but was wondering if this was the only issue. |
@murali-reddy there were many failed tests. Tried 3 runs before reverting the change to see if I can reproduce it with v1.1.1. |
7179ef4
to
3e74ad9
Compare
@hakman Looking at the logs I am not able to figure what is going wrong. All the nodes end up in non-ready state after which tests are faling as nodes are not ready
There is one test failure, I will check if that is causing any problem
|
Thanks @murali-reddy. Please let me know if you need any help debugging. |
@hakman I am not quite familiar with kops CI tests. So I am not sure how to go about root causing in efficient way. Like I mentioned in earlier comment I analyzed the logs but I can only conclude that nodes were not ready (perhaps even after applying kube-router CNI). There was error dumping kube-router logs as well. Appriciate any help with how to go about it. Do you mind doing manual install of cluster with kops and upgrading the latest version of kube-router and see if you run into any issue? |
3e74ad9
to
29fcb36
Compare
c2ae6df
to
05d9fd1
Compare
05d9fd1
to
a3526bb
Compare
The issue seems fixed in v.1.2.3 and tests pass now. |
/test all |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
https://github.com/cloudnativelabs/kube-router/releases/tag/v1.2.3