-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport rename of service-account key to 1.20 #11388
Backport rename of service-account key to 1.20 #11388
Conversation
Like #11390, this looks good, but I propose we get an upgrade e2e periodic test in asap /hold |
@justinsb should be covered by @rifelpet's new upgrade test: I see this in logs, which I am not sure if it's the expected change:
|
@hakman The LegacyFormat change is saying that it will upgrade the format (by copying it from the "master" slot to "service-account". For the "Signer" field, |
For an upgrade from 1.18 or earlier, the signer would change from "ca" to being self-signed. |
Reproducing #11390 is non-trivial (which is a good thing, as it means this isn't as critical as it first appears)! /hold cancel /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Addresses #11370