Consolidate CSI livenessprobe images for multi-arch support #11652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
olemarkus
approved these changes
May 31, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This manifest includes two liveness-probe containers but they use different images. The k8s.gcr.io image is multi-arch but the quay.io image is not. By only using the k8s.gcr.io one we should fix arm64 clusters now that EBS CSI is enabled by default.
rifelpet
force-pushed
the
csi-livenessprobe
branch
from
e0158c4 to
708a5db
Compare
k8s-ci-robot
removed
the
lgtm
|
for reference, the quay image is not referenced anywhere upstream: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/search?q=livenessprobe |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 1, 2021
…52-origin-release-1.21 Automated cherry pick of #11652: Consolidate CSI livenessprobe images for multi-arch support
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 1, 2021
…52-origin-release-1.20 Automated cherry pick of #11652: Consolidate CSI livenessprobe images for multi-arch support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This manifest includes two liveness-probe containers but they use different images.
The k8s.gcr.io image is multi-arch but the quay.io image is not.
By only using the k8s.gcr.io one we should fix arm64 clusters now that EBS CSI is enabled by default.
ref: https://testgrid.k8s.io/kops-misc#kops-aws-misc-arm64-ci&show-stale-tests=
https://storage.googleapis.com/kubernetes-jenkins/logs/e2e-kops-aws-misc-arm64-ci/1397862870238105600/artifacts/cluster-info/kube-system/ebs-csi-node-g2wjb/logs.txt