-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also set haveUserInfo=true in case --user was provided in "kops export kubecfg" #11778
Conversation
…t kubecfg" Without setting it to true, --user is completely ignored.
Hi @codablock. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I assume this must be cherry-picked into the next 1.21 beta and also into 1.20 |
@yurrriq is this the same issue you mentioned? |
/ok-to-test |
Seems related at least. |
Are you able to test this patch and see if it works for you as well? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
2 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
…778-origin-release-1.21 Automated cherry pick of #11778: Also set haveUserInfo=true in case --user was provided in
…778-origin-release-1.20 Automated cherry pick of #11778: Also set haveUserInfo=true in case --user was provided in
Without setting it to true, --user is completely ignored.