Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.20.3 #12510

Merged
merged 2 commits into from
Oct 9, 2021
Merged

Release 1.20.3 #12510

merged 2 commits into from
Oct 9, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Oct 9, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 9, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2021
@hakman
Copy link
Member Author

hakman commented Oct 9, 2021

/hold for #12509

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2021
@hakman
Copy link
Member Author

hakman commented Oct 9, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2021
@hakman hakman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 9, 2021
johngmyers
johngmyers approved these changes Oct 9, 2021
View reviewed changes
Copy link
Member

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been better to squash the two commits beforehand, but I won't insist on it.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6995b12 into kubernetes:release-1.20 Oct 9, 2021
@hakman hakman deleted the release-1.20.3 branch October 22, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@mikesplain mikesplain Awaiting requested review from mikesplain

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @k8s-ci-robot @johngmyers