Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread context through some slower AWS tasks #16037

Merged

Conversation

justinsb
Copy link
Member

There are still too many context.TODOs here for this to join all the
way up, but we should be able to better understand the slowest tasks.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2023
@k8s-ci-robot k8s-ci-robot requested a review from zetaab October 21, 2023 01:19
@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/rolling-update labels Oct 21, 2023
@justinsb justinsb force-pushed the thread_context_through_some_aws_tasks branch from 5e92d89 to d4d9e8a Compare October 25, 2023 16:14
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 28, 2023
justinsb and others added 3 commits November 9, 2023 08:17
There are still too many context.TODOs here for this to join all the
way up, but we should be able to better understand the slowest tasks.
@justinsb justinsb force-pushed the thread_context_through_some_aws_tasks branch from d4d9e8a to 49dfdab Compare November 9, 2023 13:17
@justinsb
Copy link
Member Author

justinsb commented Nov 9, 2023

/test pull-kops-e2e-k8s-aws-calico

Looks like an unrelated storage flake

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5589c83 into kubernetes:master Nov 9, 2023
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup area/provider/aws Issues or PRs related to aws provider area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants