Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kindnet: use commands instead of args for the container image #17204

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

aojea
Copy link
Member

@aojea aojea commented Jan 13, 2025

With the final 1.8.0 release of kindnet (yeah, this time the tag is final 😄 ).
One of the features is that it completely moved the image to distroless https://github.com/aojea/kindnet/releases/tag/v1.8.0

Because of that, current manifest that is using args: instead of command: fails to run https://testgrid.k8s.io/kops-distro-u2404#kops-aws-cni-kindnet

Change-Id: I9c704ba310d0dd253147a9a93211e820117af0b6
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2025
@k8s-ci-robot k8s-ci-robot requested a review from hakman January 13, 2025 07:21
@k8s-ci-robot k8s-ci-robot requested a review from zetaab January 13, 2025 07:21
@aojea
Copy link
Member Author

aojea commented Jan 13, 2025

/assign @hakman

@aojea
Copy link
Member Author

aojea commented Jan 13, 2025


Terraform validation succeeded
+ EXIT_VALUE=0
+ set +o xtrace
Cleaning up after docker in docker.
================================================================================
Waiting 30 seconds for pods stopped with terminationGracePeriod:30
Cleaning up after docker
Waiting for docker to stop for 30 seconds
Stopping Docker: docker{"component":"entrypoint","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:169","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 20m0s timeout","severity":"error","time":"2025-01-13T07:42:06Z"}

it seems the job succeeded but timed out

/test pull-kops-verify-terraform

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
@k8s-ci-robot
Copy link
Contributor

@aojea: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-kindnet-ipv6 35e7a25 link false /test pull-kops-e2e-cni-kindnet-ipv6
pull-kops-e2e-cni-kindnet 35e7a25 link false /test pull-kops-e2e-cni-kindnet

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 2b133b2 into kubernetes:master Jan 13, 2025
24 of 27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants