Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to latest release of calico #2596

Merged
merged 1 commit into from
May 18, 2017
Merged

update to latest release of calico #2596

merged 1 commit into from
May 18, 2017

Conversation

mad01
Copy link
Contributor

@mad01 mad01 commented May 18, 2017 •
edited by k8s-reviewable
Loading

Update to the latest release of the calico containers used. see #2589

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @mad01. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 18, 2017
@chrislovecnm
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 18, 2017
chrislovecnm
chrislovecnm reviewed May 18, 2017
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test, thanks for the submission!

@mad01
Copy link
Contributor Author

mad01 commented May 18, 2017 •
edited
Loading

@chrislovecnm creating a cluster with the same command that i had used in #2589, and checking that the cluster system services that is part of the create got up and running correctly. And took a extra look at the calico config job that it completed successfully since that was were it failed for me before.

@chrislovecnm chrislovecnm self-assigned this May 18, 2017
chrislovecnm
chrislovecnm approved these changes May 18, 2017
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@chrislovecnm
Copy link
Contributor

/lgtm

Waiting on e2e

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2017
@chrislovecnm chrislovecnm merged commit 251eed3 into kubernetes:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Assignees

@chrislovecnm chrislovecnm

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mad01 @k8s-ci-robot @chrislovecnm