Update weave to use the correct CIDR for pods #2717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per conversations on slack and discussions in #1171 and #2085, this pull request sets the IP range for weave by setting the env variable IPALLOC_RANGE to
.KubeControllerManager.ClusterCIDR
.Everything working as expected, see below for more testing details.
Tested Scenarios
New Cluster Creation
nonMasqueradeCIDR: 100.64.0.0/10
was keptAll networking working as expected (pod to pod, pod to external, external to pod)
Cluster Upgrade
nonMasqueradeCIDR: 100.64.0.0/10
was keptkops update cluster
showed the expected diff and I confirmed state store was updatedkops rolling-update cluster
I validated the previous deployment IP addresses:100.96.0.0/11
Note: the known issue with Weave 1.9.7 and NodePort services is still present here. That will be addressed separately.
This change is![Reviewable](https://camo.githubusercontent.com/bdad2d5a4be7a00dc3b2426ea57eabd73ef84d8ed5ee05653b2f1501b6ea93ab/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)