Initial work on kops-server #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
justinsb
force-pushed
the
kops_server
branch
4 times, most recently
from
a7cc7e9 to
161673e
Compare
BUILD
Outdated
| @@ -0,0 +1,13 @@ | |||
| load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_prefix") | |||
There was a problem hiding this comment.
Is bazel doing cross compiling yet? I thought that is was not.
There was a problem hiding this comment.
Is the hack script in core decent? Having the bazel build files updated automatically would be nice.
WORKSPACE
Outdated
| ( | ||
| "deb_busybox", | ||
| "83d809a22d765e52390c0bc352fe30e9d1ac7c82fd509e0d779d8289bfc8a53d", | ||
| "http://ftp.us.debian.org/debian/pool/main/b/busybox/busybox-static_1.22.0-9+deb8u1_amd64.deb", |
There was a problem hiding this comment.
Is core using this or the default debian image?
protokube/cmd/protokube/main.go
Outdated
| @@ -153,7 +155,18 @@ func run() error { | |||
| if internalIP == nil { | |||
| internalIP = vsphereVolumes.InternalIp() | |||
| } | |||
| <<<<<<< HEAD | |||
|
Can we get the bazel changed broken out of this PR? Also I think we already merged the clientset changes. |
justinsb
force-pushed
the
kops_server
branch
2 times, most recently
from
5f7ca21 to
e8c0e3c
Compare
|
/assign |
chrislovecnm
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is