-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase default instance root volume size #2847
increase default instance root volume size #2847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorely needed. good stuff lgtm, just fix the tests for volume size :)
I was thinking "we can't change the defaults", but I guess we can actually in a major release if we think it is a better default, and we have a release note that calls it out clearly. i.e. not specifying means "omakase" and we can change things as long as the change is clearly signposted and unlikely to actively cause problems. In this case, the only damage is finanical. It is $10 per month instead of $2 per month, per instance, so we should explain it in the release notes, but if you & geojaz both think it a better default, it works for me. |
Oh, and the three benefits from a bigger disk:
A potential downside is that a bigger disk might mean more scanning, and we've seen reports of that getting slow, but I think we need to address that anyway (in k8s/k8s) if it turns out to be an issue. |
lgtm once tests passing. If you want to start a "release-notes-1.7" doc alongside the 1.6 one as well that would be great :-) |
The one time I don't run ci - heh |
933a86d
to
1f3212c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One doc change needed then lgtm (i.e. self merge after doc change)
## Changing the root volume size or type | ||
|
||
The default volume size for Masters is 50 GB, while the default volume size for a node is 100 GB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
64/128
Merging, will send doc fix. |
Doc fix in #2873 |
Fixing #1929
masters will default 50 GB
nodes will default to 100 GB
50 and 100 just seemed weird ... doing 64 and 128 next rebase ...
This change is![Reviewable](https://camo.githubusercontent.com/bdad2d5a4be7a00dc3b2426ea57eabd73ef84d8ed5ee05653b2f1501b6ea93ab/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)