Try adding header to generated CLI docs #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
justinsb
force-pushed
the
mark_autogen_docs
branch
from
d797eb1 to
1b04aa9
Compare
cmd/kops/gen_help_docs.go
Outdated
| @@ -21,6 +21,11 @@ import ( | |||
| "github.com/spf13/cobra/doc" | |||
| ) | |||
|
|
|||
| const fileHeader = ` | |||
| <!--- This file is automatically generated by make gen-cli-docs; changes should be made in the go CLI command code --> | |||
There was a problem hiding this comment.
go CLI command code
Should we say where the code is? cmd/pkg/?
There are a lot of first timers that are making these changes. Make it simple for them.
|
I added the issue #2834 that this will close. |
justinsb
force-pushed
the
mark_autogen_docs
branch
2 times, most recently
from
d4739c1 to
a325bc7
Compare
|
Done! |
justinsb
force-pushed
the
mark_autogen_docs
branch
from
a325bc7 to
17b3fa3
Compare
|
/assign you can self merge if you beat me to it |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should stop me changing the wrong place!
Fixes: #2834