-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support china region #2947
support china region #2947
Conversation
Hi @qqshfox. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Awesome - thank you @qqshfox. Can I ask ... what image are you using? I don't have access to |
What kind of image you are referring to? AMI or dns-controller? Per PR #2889, for AMI, I copied You can also tell that we can successfully create a complete internal cluster in the existing VPC and subnets from that PR. |
To improve the stability and reduce the provision time, I downloaded assets used in provision, and uploaded them to a s3 bucket. To use these uploaded assets, I use these env vars:
and Since I modified Here is the list:
|
restore accidentally closed PR #2889