Create test for ssh-access #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
cc @BradErz feel free to review (the last commit) - I'll rebase when your PR merges. Because we default AdminAccess anyway, if you just specify ssh-access you'll still get the default admin access of 0.0.0.0/0. I suspect you realized that, though I didn't :-) In any case I think it is the UX behaviour that people would expect if they specified only ssh-access. |
justinsb
force-pushed
the
ssh_access_test
branch
from
82ea06a to
cde7093
Compare
|
Yea thats how I thought it would be best to try and keep the old behaviour. Seems fine for me, now i understand how the mapping for the tests works as well. Thanks @justinsb |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.