Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure docker on CoreOS/ContainerOS #3098

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Configure docker on CoreOS/ContainerOS #3098

merged 1 commit into from
Aug 4, 2017

Conversation

johanneswuerbach
Copy link
Contributor

@johanneswuerbach johanneswuerbach commented Jul 31, 2017 •
edited
Loading

While the installation of docker should be skipped, docker should still be
configured to allow overriding the docker config using kops.

Fixes #3057

//cc @aledbf

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @johanneswuerbach. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justinsb
Copy link
Member

justinsb commented Aug 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2017
@justinsb
Copy link
Member

justinsb commented Aug 1, 2017

Thanks @johanneswuerbach - nice fix!

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@johanneswuerbach
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@johanneswuerbach: you can't request testing unless you are a kubernetes member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johanneswuerbach
Configure docker on CoreOS/ContainerOS
798d87d 
While the installation of docker should be skipped, docker should still be
configured to allow overriding the docker config using kops.

Fixes kubernetes#3057
@johanneswuerbach johanneswuerbach force-pushed the configure-docker-on-coreos branch from 1151d75 to 798d87d Compare August 2, 2017 11:32
@k8s-github-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @johanneswuerbach @justinsb

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2017
@justinsb
Copy link
Member

justinsb commented Aug 4, 2017

/lgtm

/ok-to-test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johanneswuerbach, justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b040c11 into kubernetes:master Aug 4, 2017
@johanneswuerbach
Copy link
Contributor Author

Looks like I made a mistake and while the config is written successfully, the docker daemon is actually started before and the config only loaded on reload.

Will look into fixing that.

@johanneswuerbach johanneswuerbach deleted the configure-docker-on-coreos branch August 4, 2017 07:51
@johanneswuerbach
Copy link
Contributor Author

Fix #3134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johanneswuerbach @k8s-ci-robot @justinsb @k8s-github-robot