-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Wildcard domains returned as ASCII in dns-controller #3110
Conversation
Hi @mikesplain. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @kris-nova |
/lgtm Thanks @mikesplain |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Great! Thanks for taking a look @justinsb! |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
After running into #2671 whenever dns-controller restarted, I looked into why dns-controller successfully creates entries for wildcard domains (e.g.
*.example.com
) but after restarting, it errors, unable to find the old record. It looks amazon returns ascii\\052.example.com
instead of the*.example.com
we expect. This was a simple fix I tested in our cluster and it seems to have fixed the issue. I'm open to any changes but I think this could be a useful fix for those that may run into this in the future.This isn't a new thing apparently: boto/boto#818
Fixes #2671