-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add autoscaling:DescribeLaunchConfigurations permission #3346
add autoscaling:DescribeLaunchConfigurations permission #3346
Conversation
Hi @rushtehrani. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @chrislovecnm |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I've included this within PR #3343 which is a rework of all the IAM policies.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Thanks @rushtehrani & sorry for the delay - we had some test infrastructure problems, now resolved (hopefully). |
/test all [submit-queue is verifying that this PR is safe to merge] |
1 similar comment
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
This didn't seem to get into kops 1.7.1. I'm still seeing the problem |
Hi @dmcnaught, kops v1.7.1 only contains a vulnerability fix over v1.7.0. The autoscaling IAM change is included in the following kops release: https://github.com/kubernetes/kops/releases/tag/1.8.0-alpha.1 |
As of 0.6.1, Cluster Autoscaler supports scaling node groups from/to 0, but requires the
autoscaling:DescribeLaunchConfigurations
permission.It'd be great to have this in kops since this permission needs to be re-added back to the master policy every time the cluster is updated.