GCE: Don't remove (shared) DNS Zone #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
pkg/resources/gce.go
Outdated
| }, nil | ||
| // We never delete the hosted zone, because it is usually shared and we don't create it | ||
| return nil, nil | ||
| //if dns.IsGossipHostname(d.clusterName) { |
There was a problem hiding this comment.
Can we just remove the code?
There was a problem hiding this comment.
I want to keep it so that when we merge the Shared-resource PR we can reintroduce it.
Will add a comment.
We don't create it, we shouldn't be deleting it.
justinsb
force-pushed
the
gce_dont_remove_shared_dns_zone
branch
from
6326678 to
8ff3123
Compare
|
Added comment PTAL @chrislovecnm |
|
/lgtm Don't like commented code, but I will live with it for now ;) |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't create it, we shouldn't be deleting it.