Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing stdout on tests - cleaning house #3474

Merged
merged 1 commit into from
Oct 8, 2017
Merged

Fixing stdout on tests - cleaning house #3474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/diff/diff_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ F`
// We do need to cleanup, as otherwise we get some spurious changes on complex diffs
diffs = dmp.DiffCleanupSemantic(diffs)

t.Logf("diffs %v", diffs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - actually - this one is so that we can see the actual diff in the case that the test fails.

We choose to then set -v, which is why the results appear, but that is correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we be only outputting the log if we fail??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that's how go test worked by default. But let's get this merged..

}

actual := FormatDiff(l, r)
Expand Down
2 changes: 0 additions & 2 deletions upup/pkg/fi/vfs_castore_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ limitations under the License.
package fi

import (
"fmt"
"math/big"
"math/rand"
"testing"
Expand All @@ -35,7 +34,6 @@ func TestBigInt_Format(t *testing.T) {
s1 := r.String()
s2 := r.Text(10)

fmt.Printf("%s\n", s1)
if s1 != s2 {
t.Fatalf("%s not the same as %s", s1, s2)
}
Expand Down